Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizing terminology #1825

Conversation

blast-hardcheese
Copy link
Member

@blast-hardcheese blast-hardcheese commented Oct 10, 2023

  • swagger -> spec in most value and type positions
  • SwaggerUtil methods have been recategorized (see ModelResolver and PropMeta)
  • SwaggerUtil has been deleted (🎉)

@blast-hardcheese blast-hardcheese added the major Bump major version label Oct 10, 2023
@blast-hardcheese blast-hardcheese force-pushed the generalizing-terminology branch 2 times, most recently from 4422f35 to 3674292 Compare October 10, 2023 04:01
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (34957b4) 82.41% compared to head (401b43c) 82.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1825      +/-   ##
==========================================
- Coverage   82.41%   82.27%   -0.15%     
==========================================
  Files          93       93              
  Lines        7370     7310      -60     
  Branches      859      829      -30     
==========================================
- Hits         6074     6014      -60     
  Misses       1296     1296              
Files Coverage Δ
...s/core/src/main/scala/dev/guardrail/ReadSpec.scala 77.77% <ø> (ø)
...main/scala/dev/guardrail/core/CoreTermInterp.scala 78.48% <100.00%> (ø)
...re/src/main/scala/dev/guardrail/core/Tracker.scala 91.30% <100.00%> (ø)
...a/dev/guardrail/core/extract/VendorExtension.scala 100.00% <ø> (ø)
...a/dev/guardrail/generators/LanguageParameter.scala 97.95% <100.00%> (ø)
...la/dev/guardrail/generators/SwaggerGenerator.scala 78.23% <100.00%> (+3.03%) ⬆️
...dev/guardrail/generators/spi/CoreTermsLoader.scala 100.00% <ø> (ø)
...n/scala/dev/guardrail/runner/GuardrailRunner.scala 88.88% <ø> (ø)
...yncHttpClient/AsyncHttpClientClientGenerator.scala 94.23% <ø> (ø)
...rs/java/dropwizard/DropwizardServerGenerator.scala 95.66% <ø> (ø)
... and 14 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blast-hardcheese blast-hardcheese merged commit 0c544d3 into guardrail-dev:master Oct 10, 2023
42 of 43 checks passed
@blast-hardcheese blast-hardcheese deleted the generalizing-terminology branch October 10, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore major Bump major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant