Support ES2018 syntax by upgrading acorn #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This major version upgrade of the parser is needed to support ES2018 JavaScript syntax.
|
@tchetwin this looks great! Do you see any issue with me bumping the major version just incase there are unintended consequences of the acorn major bump? |
|
Thanks again @tchetwin! I'll get this released in a major. |
|
2.0.0 was just released! https://www.npmjs.com/package/@gulp-sourcemaps/identity-map |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to provide identity sourcemaps for JavaScript with ES2018 syntax it's
necessary to update the parser.
This PR bumps the major version of acorn from 5 to 6 to achieve this.
The acorn release notes for major version 6 are here. In particular the breaking changes listed are:
I don't think these pose a problem here.
Also included is a test fixture that fails without the changes and some tweaks
to pass the lint checks.