Update: Add and improve code coverage

.gitignore

@@ -1,15 +1,25 @@
-lib-cov
-*.seed
+# Logs
+logs
 *.log
-*.csv
-*.dat
-*.out
-*.pid
-*.gz
 
+# Runtime data
 pids
-logs
-results
+*.pid
+*.seed
+
+# Directory for instrumented libs generated by jscoverage/JSCover
+lib-cov
+
+# Coverage directory used by tools like istanbul
+coverage
+
+# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
+.grunt
+
+# Compiled binary addons (http://nodejs.org/api/addons.html)
+build/Release
 
-npm-debug.log
+# Dependency directory
+# Deployed apps should consider commenting this line out:
+# see https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git
 node_modules

lib/helpers.js

@@ -13,6 +13,8 @@ function getExtensions(lastArg){
 }
 
 function buildOnSettled(done){
+  done = done || _.noop;
+
   function onSettled(error, result){
     var settledErrors = _.where(result, { state: 'error' });
     var settledResults = _.where(result, { state: 'success' });
@@ -28,11 +30,7 @@ function buildOnSettled(done){
     }
 
     error = error || errors;
-    if(error){
-      return done(error, results);
-    }
-
-    done(undefined, results);
+    done(error, results);
   }
 
   return onSettled;

package.json

@@ -7,7 +7,8 @@
     "test": "test"
   },
   "scripts": {
-    "test": "tap ./test"
+    "test": "tap ./test/*.js",
+    "cover": "istanbul cover ./test/cover/index.js"
   },
   "repository": {
     "type": "git",
@@ -26,6 +27,8 @@
   },
   "homepage": "https://github.com/phated/bach",
   "devDependencies": {
+    "istanbul": "^0.3.0",
+    "require-dir": "^0.1.0",
     "tap": "~0.4.8"
   },
   "dependencies": {

test/cover/index.js

@@ -0,0 +1,3 @@
+'use strict';
+
+require('require-dir')('../');

test/getExtensions.js

@@ -0,0 +1,17 @@
+'use strict';
+
+var test = require('tap').test;
+
+var getExtensions = require('../lib/helpers').getExtensions;
+
+test('should return the argument if it is an object', function(t){
+  var obj = {};
+  t.equal(getExtensions(obj), obj, 'should be the same object');
+  t.end();
+});
+
+test('should return a new object if argument is not an object', function(t){
+  var fn = function(){};
+  t.deepEqual(getExtensions(fn), {}, 'should be an object');
+  t.end();
+});

test/onSettled.js

@@ -0,0 +1,23 @@
+'use strict';
+
+var test = require('tap').test;
+
+var onSettled = require('../lib/helpers').onSettled;
+
+var errors = [
+  { state: 'error', value: new Error('Error 1') },
+  { state: 'error', value: new Error('Error 2') }
+];
+
+test('should group all errors', function(t){
+  onSettled(function(errs, results){
+    t.equal(errs.length, 2, 'errors should contain both errors');
+    t.notOk(results, 'results should contain nothing');
+    t.end();
+  })(null, errors);
+});
+
+test('should handle the no callback case', function(t){
+  onSettled()(null, errors);
+  t.end();
+});