fix: Avoid pushing additional paths to queue when error occurs #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned at #122 (comment), @joshhunt pointed out that additional paths would be pushed to the queue if a symlink error occurred.
Here, I've pulled in our
now-and-later
dependency to iterate over thedirents
with an iterator that handle async operations. This allows us to avoid pushing more items into the queue if an error occurs in the symlink resolution.I couldn't find a good way to write a unit test for this because we don't expose the walker and the stream won't emit more
data
events after it has been destroyed. However, I did verify the behavior usingconsole.log
statements and adding a file namedz-test.txt
to the symlink directory.