Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy to clipboard" button can't be seen on code snippets #129

Closed
phated opened this issue Oct 21, 2020 · 5 comments
Closed

"Copy to clipboard" button can't be seen on code snippets #129

phated opened this issue Oct 21, 2020 · 5 comments

Comments

@phated
Copy link
Member

phated commented Oct 21, 2020

I just noticed that if you hover on a code snippet, the "Copy" button appears but you can't really see it because of the dark background and black text. We should fix that styling.

@ghost
Copy link

ghost commented Oct 22, 2020

I did a quick fix #130
but, I think updating docusaurus to v2.0.0-alpha.66 will fix the problem.

@phated
Copy link
Member Author

phated commented Oct 23, 2020

Thanks! I'll make a note about that in our upgrade issue. The upgrade needs a bunch of care to do and no one has taken it on yet.

@phated
Copy link
Member Author

phated commented Oct 23, 2020

Temporarily fixed by #130

@phated phated closed this as completed Oct 23, 2020
@ghost
Copy link

ghost commented Oct 24, 2020

@phated My pleasure. btw this is my first ever contribution to the open source 🥰
Yes, I tried to upgrade, but it's a bit challenging 😄

I will try to upgrade to the latest version 🤞

@phated
Copy link
Member Author

phated commented Oct 25, 2020

@uplancer Oh cool! I'm glad we has something you could work on; you did great work!

Please let me know on the upgrade issue if you need any guidance. I haven't tried upgrading and I know they changed a lot, but I have spent a lot of time looking at Docusaurus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant