Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup implementation when we drop older node support #9

Open
phated opened this issue Apr 18, 2022 · 0 comments
Open

Cleanup implementation when we drop older node support #9

phated opened this issue Apr 18, 2022 · 0 comments

Comments

@phated
Copy link
Member

phated commented Apr 18, 2022

We needed 2 workarounds in the implementation of this:

  1. Node <12 didn't handle BOMs correctly in streaming mode
  2. Before lib: ensure TextDecoder only removes utf8 BOM on utf8 encoding nodejs/node#42779 - node didn't handle BOMs correctly on non-UTF8 encodings

Once we support only node versions with the fix, we should cleanup this implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phated