Fix: Avoid setting displayName on series/parallel functions (ref gulp…

…js/gulp#2270) (#91)
gulpjs · Apr 6, 2019 · 1ee58b1 · 1ee58b1
1 parent f94fd87
commit 1ee58b1
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 8 deletions.
diff --git a/lib/parallel.js b/lib/parallel.js
@@ -13,14 +13,13 @@ function parallel() {
   var args = normalizeArgs(this._registry, arguments);
   var extensions = createExtensions(this);
   var fn = create(args, extensions);
-
-  fn.displayName = '<parallel>';
+  var name = '<parallel>';
 
   metadata.set(fn, {
-    name: fn.displayName,
+    name: name,
     branch: true,
     tree: {
-      label: fn.displayName,
+      label: name,
       type: 'function',
       branch: true,
       nodes: buildTree(args),

diff --git a/lib/series.js b/lib/series.js
@@ -13,14 +13,13 @@ function series() {
   var args = normalizeArgs(this._registry, arguments);
   var extensions = createExtensions(this);
   var fn = create(args, extensions);
-
-  fn.displayName = '<series>';
+  var name = '<series>';
 
   metadata.set(fn, {
-    name: fn.displayName,
+    name: name,
     branch: true,
     tree: {
-      label: fn.displayName,
+      label: name,
       type: 'function',
       branch: true,
       nodes: buildTree(args),

diff --git a/test/parallel.js b/test/parallel.js
@@ -146,4 +146,10 @@ describe('parallel', function() {
       done();
     });
   });
+
+  it('should not register a displayName on the returned function by default', function(done) {
+    var task = taker.parallel(fn1);
+    expect(task.displayName).toEqual(undefined);
+    done();
+  });
 });
diff --git a/test/series.js b/test/series.js
@@ -147,4 +147,9 @@ describe('series', function() {
     });
   });
 
+  it('should not register a displayName on the returned function by default', function(done) {
+    var task = taker.series(fn1);
+    expect(task.displayName).toEqual(undefined);
+    done();
+  });
 });