Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Typescript v5 support #60

Closed
4 tasks done
gund opened this issue Feb 22, 2023 · 17 comments · Fixed by #63
Closed
4 tasks done

Typescript v5 support #60

gund opened this issue Feb 22, 2023 · 17 comments · Fixed by #63
Labels
enhancement New feature or request released

Comments

@gund
Copy link
Owner

gund commented Feb 22, 2023

This issue tracks a support for Typescript v5.

Before the following steps are done Typescript v5 support will NOT land into latest release:

  • Update Typescript to v5 in dev dependencies and make sure tests are passing
  • Add backwards compatibility tests for Typescript v4
  • Add stable Typescript v5 to peer dependencies
  • Typescript v5 is released as stable

If you already would like to play around with Typescript v5 beta you can try @next NPM tag version of this package which includes Typescript v5 beta in it's peer dependencies.

If you find any issues with it you may report them in this issue or open a PR to next branch with a fix.
Any fixes merged into next branch will be automatically released under @next NPM release tag.

@gund gund added the enhancement New feature or request label Feb 22, 2023
@gund gund pinned this issue Feb 22, 2023
@Profesor08
Copy link
Contributor

Profesor08 commented Feb 23, 2023

There are some issues with tsconfig.test.json, which cause tests to fail, all of them. May be packages updating and project reconfiguring will solve.

@josundt
Copy link

josundt commented Mar 20, 2023

Please prioritize this issue.
The TypeScript peerDependency prevents me from upgrading our projects to TypeScript 5.0...

@dscalzi
Copy link

dscalzi commented Mar 20, 2023

@josundt you can try installing 1.4.0-next.1

@gund
Copy link
Owner Author

gund commented Mar 31, 2023

Final release for TS v5 support has been published in v1.4.0-next.2!

Could you please try it out on your projects and let me know if it's working fine so we can proceed with the latest release?

@amikheychik
Copy link

@gund I've just tried v1.4.0-next.2 with TS v5.0.3 and getting FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory as on v1.3.0. (https://gist.github.com/amikheychik/2c138a6f7be88c0d2723d52834bde2cd)

@maxnowack
Copy link

@gund I've just tried v1.4.0-next.2 with TS v5.0.3 and getting FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory as on v1.3.0. (gist.github.com/amikheychik/2c138a6f7be88c0d2723d52834bde2cd)

Same issue on my side

@gund
Copy link
Owner Author

gund commented Mar 31, 2023

Wow that is unexpected as we did not change any code at all since the last release...
Does anyone have more logs maybe on last stack trace to see maybe there is somewhere an infinity loop or something?
I have completely no idea where to look right now 🤷‍♂️

@gund
Copy link
Owner Author

gund commented Mar 31, 2023

Btw are you testing new version with the updated typescript-eslint package versions?
At least v5.55.0 is needed for TS5 compatibility.

@maxnowack
Copy link

maxnowack commented Mar 31, 2023

I'm using v5.57.0 and typescript @ v5.0.3. I digged down a bit and it seems, that the error isn't related to eslint-plugin-deprecation as the issue also occurs if I remove this package and the related configuration.
@amikheychik can you confirm this?

@amikheychik
Copy link

@maxnowack you're right. I just assumed it's eslint-plugin-deprecation, because it was the only one with version limitation and not latest.

@gund sorry about false alarm :)

@gund
Copy link
Owner Author

gund commented Mar 31, 2023

Oh well that's good. But does it mean that eslint and typescript v5 does not work in general right now?
Did you manage to execute any rules at all with the typescript v5? Maybe just with this rule enabled to see if we can release v5 support to latest?

@amikheychik
Copy link

@maxnowack it looks like in my case, the problem is with tsconfig.json: I'm extending a configuration from another package and it was not working. Once I copied the config, the build started working and after that the linters worked fine too.

@gund
Copy link
Owner Author

gund commented Mar 31, 2023

Nice, so we have one confirmation that support for v5 works. Let's wait for a few more and then we can publish it on latest.
I think by the end of today we can do it.
Also there is still probably a 24hr cooldown from NPM until we can publish next release as it was published yesterday by mistake in the automation - so anyway we have to wait a bit 😁

@SchroederSteffen
Copy link

I tried it in a NestJS project together with several other ESLint plugins and it worked fine. 👍

@mscharley
Copy link

I haven't tried v1.4.0-next.2 yet, but I was using v1.4.0-next.1 in a few projects without issue.

@josundt
Copy link

josundt commented Apr 1, 2023

Same experience as mscharley

@gund gund closed this as completed in #63 Apr 1, 2023
@github-actions
Copy link

github-actions bot commented Apr 1, 2023

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gund gund unpinned this issue Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants