-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couldn't change folder colour #10
Comments
Same problem for me. For the empty color list, I found in another issue that you just need to rename the folder '64' in 'places' to 'scalable' then, the script is able to read the theme's colors. But even after this issue is fixed, I get the same error when trying to change folders colors. |
Any updates on this issue? I am having the same problem. These are some of the best icons I have used! |
CAUSE:The developer used "64" instead of "scalable" as a directory title under "places" directory for this dark icon theme, and his bash script "suru-plus-folders" is written to search for colored SVG files in "places/scalable" and NOT "places/64", and so it finds nothing. SOLUTION:
Ln 122: if [ -e "$THEME_DIR/places/64/folder-$color.svg" ]; then
Ta da! Note: This is a temporary solution until someone opens a pull request and edit the code of the "suru-plus-dark" icon theme itself. |
@ProfoundVoid Please, it will be better if you could make pull request to fix this issue, instead of making everyone edit the bash script. It will be more convenient. |
Unfortunately, I'm no developer, and I don't know how to code, however, somehow I could solve this issue for myself, and I liked to share it. I think the optimal solution is to open a pull request and edit the code of the "suru-plus-dark" icon theme itself just like the developer did to the "suru-plus" one here: Replaced '64' for 'scalable' in the folder 'places'. Consider this as a note to whoever can do it! Regards |
I'm testing Suru++, Suru++-Light, and Suru++-Dark. The first two folder colours are fine and can be changed, but not with the Suru++-Dark.
When i tried to show the list of variants available using
suru-plus-folders -l --theme Suru++-Dark,
it showed a blank list.The text was updated successfully, but these errors were encountered: