Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't change folder colour #10

Open
risalfajar opened this issue Jan 31, 2020 · 7 comments
Open

Couldn't change folder colour #10

risalfajar opened this issue Jan 31, 2020 · 7 comments

Comments

@risalfajar
Copy link

I'm testing Suru++, Suru++-Light, and Suru++-Dark. The first two folder colours are fine and can be changed, but not with the Suru++-Dark.

When i tried to show the list of variants available using suru-plus-folders -l --theme Suru++-Dark, it showed a blank list.

no colour variants

@lyndhurst
Copy link

Same problem for me.

For the empty color list, I found in another issue that you just need to rename the folder '64' in 'places' to 'scalable' then, the script is able to read the theme's colors.

But even after this issue is fixed, I get the same error when trying to change folders colors.

@maxfinnsjo
Copy link

Any updates on this issue? I am having the same problem. These are some of the best icons I have used!

@ghost
Copy link

ghost commented Jun 26, 2020

CAUSE:

The developer used "64" instead of "scalable" as a directory title under "places" directory for this dark icon theme, and his bash script "suru-plus-folders" is written to search for colored SVG files in "places/scalable" and NOT "places/64", and so it finds nothing.

SOLUTION:

  1. Copy the bash script file to your home directory:

cp /usr/bin/suru-plus-folders ~/

  1. Edit the bash script file "suru-plus-folders" and rename the 3 lines with the word "scalable" (use CTRL+F to find them easily) to "64" and save:

Ln 122: if [ -e "$THEME_DIR/places/64/folder-$color.svg" ]; then
Ln 134: icon_file=$(readlink -f "$THEME_DIR/places/64/folder.svg")
Ln 265: local -a sizes=(64)

  1. Run the modified script using the "bash" command (only for Suru++-Dark):

bash suru-plus-folders -l --theme Suru++-Dark

bash suru-plus-folders -C blue --theme Suru++-Dark

  1. You will be able to continue running the original script with other icon themes:

suru-plus-folders -l --theme Suru++

Ta da!

Note: This is a temporary solution until someone opens a pull request and edit the code of the "suru-plus-dark" icon theme itself.

@risalfajar
Copy link
Author

@ProfoundVoid Please, it will be better if you could make pull request to fix this issue, instead of making everyone edit the bash script. It will be more convenient.

@ghost
Copy link

ghost commented Jun 27, 2020

@ProfoundVoid Please, it will be better if you could make pull request to fix this issue, instead of making everyone edit the bash script. It will be more convenient.

Unfortunately, I'm no developer, and I don't know how to code, however, somehow I could solve this issue for myself, and I liked to share it.
I'm simply an intermediate/advanced user of Linux.

I think the optimal solution is to open a pull request and edit the code of the "suru-plus-dark" icon theme itself just like the developer did to the "suru-plus" one here: Replaced '64' for 'scalable' in the folder 'places'. Consider this as a note to whoever can do it!

Regards

@gusbemacbe
Copy link
Owner

Hello everybody!

Sorry for my longer absence. I did not update Suru++ projects since last July because I am mostly focused on @Bonandry's Adwaita++ and Yaru++ projects. When I will be donw with @Bonandry's projects, I will focus on my projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@maxfinnsjo @gusbemacbe @risalfajar @lyndhurst and others