Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having include be an empty array breaks type definitions #23

Closed
deanolium opened this issue Dec 9, 2021 · 2 comments
Closed

Having include be an empty array breaks type definitions #23

deanolium opened this issue Dec 9, 2021 · 2 comments

Comments

@deanolium
Copy link

The recent change on v1.1.3 to set include to an empty array causes the underlying tsc to ignore declaration files, which means things like importing png files now comes up as errors.

This change is also broken on the automated testing, and so should never have been made a release. It should also be a toggle-able option rather than a forced change.
@deanolium
Copy link
Author

Realised this is a duplicate of #20 so closing

@gustavopch
Copy link
Owner

I'm locking so the discussion is centralized in #20.

Repository owner locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deanolium @gustavopch