Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mismatch between code and type #384

Closed
loynoir opened this issue Aug 6, 2023 · 1 comment · Fixed by #396
Closed

mismatch between code and type #384

loynoir opened this issue Aug 6, 2023 · 1 comment · Fixed by #396

Comments

@loynoir
Copy link
Contributor

loynoir commented Aug 6, 2023 •
edited
Loading

https://github.com/guybedford/es-module-shims/blob/1.8.0/index.d.ts#L52

dts say skip is RegExp.

https://github.com/guybedford/es-module-shims/blob/1.8.0/src/env.js#L51-L59

But the js code treat it like RegExp | Array<string> | string

Is it inaccurate type?

Or, is it the wasm implement is using that type?
@guybedford
Copy link
Owner

We should probably fix the JS code to support an explicit regexp, by doing an instanceof check I think?

@koddsson koddsson assigned koddsson and unassigned koddsson Nov 6, 2023
@koddsson koddsson mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the skip option koddsson/es-module-shims
3 participants
@koddsson @guybedford @loynoir