Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Valid characters in XML (allow \n and \r when saving) #286

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Fix Valid characters in XML (allow \n and \r when saving) #286

merged 1 commit into from
Mar 16, 2017

Conversation

Rycochet
Copy link
Contributor

See https://en.wikipedia.org/wiki/Valid_characters_in_XML - the previous PR (#262) stripped out the valid newline (\x09) and carriage return (\x0D) characters, although the test spec was correct.
Fix #207
Fix #274

See https://en.wikipedia.org/wiki/Valid_characters_in_XML - the previous PR (#262) stripped out the valid newline (\x09) and carriage return (\x0D) characters.
Fix #207
Fix #274
@guyonroche guyonroche merged commit a2d2ce6 into exceljs:master Mar 16, 2017
@Rycochet Rycochet deleted the patch-1 branch March 17, 2017 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants