Don't break when loading an Excel file containing a chartsheet #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezny
pushed a commit
to atriumlts/exceljs
that referenced
this pull request
Jan 2, 2019
commit 52ddb6b Author: Elliott Rezny <elliott@atrium.co> Date: Mon Dec 31 16:47:16 2018 -0800 build commit d924091 Author: scott <scott@atriumlts.com> Date: Wed Jan 3 13:14:28 2018 -0800 Missing dist files commit e966e71 Author: scott <scott@atriumlts.com> Date: Wed Jan 3 13:13:57 2018 -0800 Remove namespace specific things to parse malformed XML commit f6f9cb4 Author: scott <scott@atriumlts.com> Date: Tue Jan 2 14:11:38 2018 -0800 Sax shim for XMLNS parsing for importing excel files which have namespaces for whatever reason commit 66f8c2e Author: scott <scott@justmachinery.net> Date: Fri Dec 29 17:27:50 2017 -0800 Build for previous commit commit ce033ef Author: scott <scott@justmachinery.net> Date: Fri Dec 29 17:27:07 2017 -0800 Tentative fix for malformed app.xml commit 2a2b091 Author: scott <scott@justmachinery.net> Date: Fri Dec 29 16:39:13 2017 -0800 Unignore build/dist to host package on git commit b8a21fe Author: scott <scott@justmachinery.net> Date: Fri Dec 22 19:25:29 2017 -0800 Testing iterative calculation output commit f83fad4 Author: Guyon <guyon@live.com> Date: Tue Jan 16 20:05:30 2018 +0000 0.8.2 commit 0eacc22 Author: guyon <guyon@live.com> Date: Tue Jan 16 20:04:46 2018 +0000 Doc commit ace1e4d Merge: d17b361 b9059a3 Author: Guyon Roche <guyon@live.com> Date: Tue Jan 16 19:56:06 2018 +0000 Merge pull request exceljs#471 from robbi/hotfix/sheet_order#257 Hotfix/sheet order#257 commit d17b361 Merge: 3950e0e fd0bf4c Author: Guyon Roche <guyon@live.com> Date: Tue Jan 16 19:51:08 2018 +0000 Merge pull request exceljs#466 from peakon/fix/unbreakChartsheet Don't break when loading an Excel file containing a chartsheet commit b9059a3 Author: Olivier Robin <olivier.robin@bpce-it.fr> Date: Sun Jan 7 18:42:58 2018 +0100 Fix linting issue commit 7a53221 Author: Olivier Robin <olivier.robin@bpce-it.fr> Date: Sun Jan 7 18:40:14 2018 +0100 Add worksheet order number commit db408fc Author: Olivier Robin <olivier.robin@bpce-it.fr> Date: Sun Jan 7 18:39:20 2018 +0100 Add test case for the issue exceljs#257 commit fd0bf4c Author: Andreas Lind <andreas.lind@peakon.com> Date: Tue Dec 19 14:12:10 2017 +0100 Don't break when loading an Excel file containing a chartsheet Test case found here: http://www.excel-easy.com/examples/excel-files/chart-sheet.xlsx
|
It's still breaking when the excel file contains a chart sheet :( any ideas ! |
where is documentation to show a chart ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem where exceljs crashed on a customer-uploaded excel file containing chartsheets. It's an entirely new concept to me, and it looks like exceljs doesn't understand those at the moment, so I chose to do a minimal fix so we don't crash, at least :)
Test case found here: http://www.excel-easy.com/examples/excel-files/chart-sheet.xlsx