From f476d8665a6b49755796a49f86179fe8f97b09e4 Mon Sep 17 00:00:00 2001
From: daniele d'angeli <dangeli88.daniele@gmail.com>
Date: Mon, 15 Sep 2014 13:17:41 +0100
Subject: [PATCH] added description interface to extend it

description interface

fixed op

stashed parameters

Update DescriptionInterface.php

changed attribute to private
---
 src/Description.php           |   2 +-
 src/DescriptionInterface.php  | 109 ++++++++++++++++++++++++++++++++++
 src/GuzzleClient.php          |  12 ++--
 src/GuzzleClientInterface.php |   2 +-
 src/Operation.php             |   6 +-
 src/Parameter.php             |   2 +-
 6 files changed, 121 insertions(+), 12 deletions(-)
 create mode 100644 src/DescriptionInterface.php

diff --git a/src/Description.php b/src/Description.php
index 56d4507e..75ee68e6 100644
--- a/src/Description.php
+++ b/src/Description.php
@@ -7,7 +7,7 @@
 /**
  * Represents a Guzzle service description
  */
-class Description
+class Description implements DescriptionInterface
 {
     /** @var array Array of {@see OperationInterface} objects */
     private $operations = [];
diff --git a/src/DescriptionInterface.php b/src/DescriptionInterface.php
new file mode 100644
index 00000000..3f776193
--- /dev/null
+++ b/src/DescriptionInterface.php
@@ -0,0 +1,109 @@
+<?php
+
+namespace GuzzleHttp\Command\Guzzle;
+
+use GuzzleHttp\Url;
+
+interface DescriptionInterface
+{
+    /**
+     * Get the basePath/baseUrl of the description
+     *
+     * @return Url
+     */
+    public function getBaseUrl();
+
+    /**
+     * Get the API operations of the service
+     *
+     * @return Operation[] Returns an array of {@see Operation} objects
+     */
+    public function getOperations();
+
+    /**
+     * Check if the service has an operation by name
+     *
+     * @param string $name Name of the operation to check
+     *
+     * @return bool
+     */
+    public function hasOperation($name);
+
+    /**
+     * Get an API operation by name
+     *
+     * @param string $name Name of the command
+     *
+     * @return Operation
+     * @throws \InvalidArgumentException if the operation is not found
+     */
+    public function getOperation($name);
+
+    /**
+     * Get a shared definition structure.
+     *
+     * @param string $id ID/name of the model to retrieve
+     *
+     * @return Parameter
+     * @throws \InvalidArgumentException if the model is not found
+     */
+    public function getModel($id);
+
+    /**
+     * Get all models of the service description.
+     *
+     * @return array
+     */
+    public function getModels();
+
+    /**
+     * Check if the service description has a model by name.
+     *
+     * @param string $id Name/ID of the model to check
+     *
+     * @return bool
+     */
+    public function hasModel($id);
+    
+    /**
+     * Get the API version of the service
+     *
+     * @return string
+     */
+    public function getApiVersion();
+
+    /**
+     * Get the name of the API
+     *
+     * @return string
+     */
+    public function getName();
+
+    /**
+     * Get a summary of the purpose of the API
+     *
+     * @return string
+     */
+    public function getDescription();
+
+    /**
+     * Format a parameter using named formats.
+     *
+     * @param string $format Format to convert it to
+     * @param mixed  $input  Input string
+     *
+     * @return mixed
+     */
+    public function format($format, $input);
+
+    /**
+     * Get arbitrary data from the service description that is not part of the
+     * Guzzle service description specification.
+     *
+     * @param string $key Data key to retrieve or null to retrieve all extra
+     *
+     * @return null|mixed
+     */
+    public function getData($key = null);
+
+} 
diff --git a/src/GuzzleClient.php b/src/GuzzleClient.php
index 63f9d873..e08158a3 100644
--- a/src/GuzzleClient.php
+++ b/src/GuzzleClient.php
@@ -37,13 +37,13 @@ class GuzzleClient extends AbstractClient implements GuzzleClientInterface
      * - response_locations: Associative array of location types mapping to
      *   ResponseLocationInterface objects.
      *
-     * @param ClientInterface   $client      Client used to send HTTP requests
-     * @param Description       $description Guzzle service description
-     * @param array             $config      Configuration options
+     * @param ClientInterface        $client      Client used to send HTTP requests
+     * @param DescriptionInterface   $description Guzzle service description
+     * @param array                  $config      Configuration options
      */
     public function __construct(
         ClientInterface $client,
-        Description $description,
+        DescriptionInterface $description,
         array $config = []
     ) {
         parent::__construct($client, $config);
@@ -73,11 +73,11 @@ public function getDescription()
      * Creates a callable function used to create command objects from a
      * service description.
      *
-     * @param Description $description Service description
+     * @param DescriptionInterface $description Service description
      *
      * @return callable Returns a command factory
      */
-    public static function defaultCommandFactory(Description $description)
+    public static function defaultCommandFactory(DescriptionInterface $description)
     {
         return function (
             $name,
diff --git a/src/GuzzleClientInterface.php b/src/GuzzleClientInterface.php
index b75599ae..a38c4af9 100644
--- a/src/GuzzleClientInterface.php
+++ b/src/GuzzleClientInterface.php
@@ -12,7 +12,7 @@ interface GuzzleClientInterface extends ServiceClientInterface
     /**
      * Returns the service description used by the client
      *
-     * @return Description
+     * @return DescriptionInterface
      */
     public function getDescription();
 }
diff --git a/src/Operation.php b/src/Operation.php
index caa29135..9ae4bf5e 100644
--- a/src/Operation.php
+++ b/src/Operation.php
@@ -45,11 +45,11 @@ class Operation implements ToArrayInterface
      * - additionalParameters: (null|array) Parameter schema to use when an
      *   option is passed to the operation that is not in the schema
      *
-     * @param array             $config      Array of configuration data
-     * @param Description $description Service description used to resolve models if $ref tags are found
+     * @param array                 $config      Array of configuration data
+     * @param DescriptionInterface  $description Service description used to resolve models if $ref tags are found
      * @throws \InvalidArgumentException
      */
-    public function __construct(array $config = [], Description $description)
+    public function __construct(array $config = [], DescriptionInterface $description)
     {
         static $defaults = [
             'name' => '',
diff --git a/src/Parameter.php b/src/Parameter.php
index 2b7a972a..959598dd 100644
--- a/src/Parameter.php
+++ b/src/Parameter.php
@@ -137,7 +137,7 @@ public function __construct(array $data = [], array $options = [])
 
         if (isset($options['description'])) {
             $this->serviceDescription = $options['description'];
-            if (!($this->serviceDescription instanceof Description)) {
+            if (!($this->serviceDescription instanceof DescriptionInterface)) {
                 throw new \InvalidArgumentException('description must be a Description');
             }
             if (isset($data['$ref'])) {