Exceptions Thrown From Subscribers Are Ignored?

[GrahamCampbell]

For some reason the code continues without throwing this exception at a later point? This used to work in guzzle 4. I've done some debugging, and this exception is definitely thrown from this subscriber, but for some reason guzzle ignores it, and continues anyway?

[mtdowling]

The exception is associated with the transaction, the error event is emitted, then to end event is emitted. The command layer process event is emitted for both successful and error conditions in the request life cycle. If unhandled, the exception is thrown. The point is that Guzzle ensures that the events are always emitted to allow listeners to handle error conditions.

On Oct 25, 2014, at 12:19 PM, Graham Campbell notifications@github.com wrote:

For some reason the code continues without throwing this exception? This used to work in laravel 4. I've done some debugging, and this exception is definitely thrown from this subscriber, but for some reason guzzle ignores it, and continues anyway?

—
Reply to this email directly or view it on GitHub.

[GrahamCampbell]

How come the behaviour has changed between guzzle 4 and guzzle 5?

[mtdowling]

Can you be more specific? The reason it changed is it's a better API that has specific state transitions.

On Oct 25, 2014, at 1:56 PM, Graham Campbell notifications@github.com wrote:

How come the behaviour is changed between guzzle 4 and guzzle 5?

—
Reply to this email directly or view it on GitHub.

[GrahamCampbell]

I was expecting an exception to be thrown at the very end, but instead, the model array was returned.

[GrahamCampbell]

Your docs say that:

When the CommandErrorEvent is not intercepted with a result, then a GuzzleHttp\Command\Exception\CommandException is thrown.

This never happened?

[GrahamCampbell]

Should we not be checking getException in https://github.com/guzzle/guzzle-services/blob/master/src/Subscriber/ProcessResponse.php#L68?

[GrahamCampbell]

What do you make of #59 @mtdowling?

[mtdowling]

I'm AFK right now, but yes, there's a bug there because it needs to check for an exception before creating a result.

On Oct 25, 2014, at 2:57 PM, Graham Campbell notifications@github.com wrote:

Should we not be checking getException in https://github.com/guzzle/guzzle-services/blob/master/src/Subscriber/ProcessResponse.php#L68?

—
Reply to this email directly or view it on GitHub.