Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA-SHA1 signing method is not working #15

Closed
Wirone opened this issue Jul 17, 2014 · 3 comments
Closed

RSA-SHA1 signing method is not working #15

Wirone opened this issue Jul 17, 2014 · 3 comments

Comments

@Wirone
Copy link

Wirone commented Jul 17, 2014

Problem is with these lines in GuzzleHttp\Subscriber\Oauth\Oauth1::sign_RSA_SHA1():

$privateKey = openssl_pkey_get_private(
    file_get_contents($this->config['consumer_secret']),
    $this->config['consumer_secret']
);

We have to use $this->config['consumer_secret'] for private key's path, but then $this->config['consumer_secret'] is also used as passphrase and it's not working.

I have two ideas:

  • there should be one additional private_key attribute in constructor's $config so sign_RSA_SHA1() could use $this->config['private_key']. Maybe $this->config['private_key_passphrase'] also? In my opinion it would be most readable.
  • sign_RSA_SHA1() could use $this->config['consumer_key'] for private key's path and $this->config['consumer_secret'] for optional passphrase. But it could be misleading.
@Wirone
Copy link
Author

Wirone commented Mar 20, 2015

Great! When new release will be available for Composer?

@Brainshack
Copy link

Will there be a version of this fix for guzzle 5?

@Aerendir
Copy link

I think this can be closed...

@Wirone Wirone closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants