Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors from chunkGetItem are not handled #140

Closed
oskbor opened this issue Feb 8, 2023 · 0 comments · Fixed by #145
Closed

Errors from chunkGetItem are not handled #140

oskbor opened this issue Feb 8, 2023 · 0 comments · Fixed by #145

Comments

@oskbor
Copy link
Contributor

oskbor commented Feb 8, 2023 •
edited
Loading

Errors from chunkGetItem seems to not be handled and instead I get the classic Uncaught (in promise) error
image

This is unfortunate because zarr.js happily returns an array full of zeroes and there is no error for me to catch or react on.

I think the issue might be that onIdle from p-queue never throws?

The error I am seeing originates from this line but I think similar issues could be present at more places in the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(error): Fix error passthrough in queued tasks az0uz/zarr.js
1 participant
@oskbor