Fix issue where page bundle images fail to load #238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I just want to say thanks for the awesome theme.
I noticed an issue where images in page bundles fail to load if the site is not deployed to the root. For example, if you deploy the site to www.example.com/projects/info.
To reproduce the issue, in the
say-hello-to-doks
blog post embed thesay-hello-to-doks.png
and run a build.Checking out the resulting
index.html
, the first entry indata-srcset
has an absolute URL but the rest are relative URL's. The relative links will fail to load once deployed since the default config is using canonical URL's with a baseURL.This seems because
RelPermalink
is used in theimg
shortcode. Switch toPermalink
and rebuild to fix the issue.