fix(flexsearch): separate chain of calls into statements #739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the search bar continue to work when many (2000+) pages are added.
Summary
This adjusts the way in which the search index is built so that the call stack is not exceeded on some browsers (see #738 for browser compatibility). I'm not familiar with Hugo templating so if there's a preferred way, we can go that route!
Basic example
Previously, the compiled template would add to the array
index
by chaining.add()
calls.Now, this PR would make the resulting template add to
index
without chaining, something like:Motivation
Closes #738
Checks
npm run test