Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SVG favicon if it exists #754

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Use SVG favicon if it exists #754

merged 1 commit into from
Jun 21, 2022

Conversation

ROCKTAKEY
Copy link
Contributor

Summary

Use SVG favicon if "static/favicon.svg" exists.

Basic example

  1. Add "favicon.svg" file to "static" directory
  2. hugo serve
  3. SVG favicon is used on localhost:1313://.

Motivation

SVG favicon is useful since we should manage only one image, while png favicon is varied like 16x16 and 32x32.

Checks

  • Read Create a Pull Request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test

@h-enk
Copy link
Member

h-enk commented May 19, 2022

Nice!

I'm not sure if the order of favicons is relevant — see also SVG, Favicons, and All the Fun Things We Can Do With Them.

I will test a few things and get back to you.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jun 19, 2022
@h-enk h-enk removed the stale label Jun 20, 2022
@h-enk h-enk added this to the v0.5.0 milestone Jun 21, 2022
h-enk
h-enk approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Tested + verified.

Resources

@h-enk h-enk merged commit 62d2427 into thuliteio:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-enk h-enk h-enk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ROCKTAKEY @h-enk