Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotImplementedError: StringColumn::replace_values() not implemented #1523

Closed
arnocandel opened this issue Jan 9, 2019 · 3 comments · Fixed by #1524
Closed

NotImplementedError: StringColumn::replace_values() not implemented #1523

arnocandel opened this issue Jan 9, 2019 · 3 comments · Fixed by #1524
Assignees
@st-pasha
Labels
improve Improvement of an existing functionality
Milestone
Release 0.8.0

Comments

@arnocandel
Copy link
Member

After refactor - this feature was lost, it seems. Needed for DAI.
@arnocandel arnocandel added bug Any bugs / errors in datatable; however for severe bugs use [segfault] label refactor Internal code changes, clean-ups or reorganizations that are not externally visible labels Jan 9, 2019
@arnocandel
Copy link
Member Author

https://github.com/h2oai/h2oai/issues/6271

@st-pasha
Copy link
Contributor

st-pasha commented Jan 9, 2019

It was never implemented, only now we started to throw a proper error: 4c39335#diff-7252009faeff84b6ca99ff2ace337bdf

Of course if DAI actually needs it, then we should go ahead and implement.

@st-pasha st-pasha added improve Improvement of an existing functionality and removed bug Any bugs / errors in datatable; however for severe bugs use [segfault] label refactor Internal code changes, clean-ups or reorganizations that are not externally visible labels Jan 9, 2019
@arnocandel
Copy link
Member Author

arnocandel commented Jan 9, 2019 •
edited
Loading

how come this works in 0.7.0.dev428

    table = dt.Frame(['hi'])
    table.replace(['hi'], 'boo')
    assert table[0, 0] == 'boo'

ah - not table[some_rows, some_cols] = strings

@st-pasha st-pasha mentioned this issue Jan 9, 2019
Merged
@st-pasha st-pasha added this to the Release 0.8.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st-pasha st-pasha

Labels
improve Improvement of an existing functionality
Projects
None yet
Milestone
Release 0.8.0
Development

Successfully merging a pull request may close this issue.

Implement updating values within string columns h2oai/datatable
2 participants
@st-pasha @arnocandel