Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: have the default NimbleCharacteristicsCallbacks print the uuid of the characteristics #852

Open
jackjansen opened this issue Jan 10, 2025 · 1 comment

Comments

@jackjansen
Copy link

Not specifying your own NimbleCharacteristicsCallbacks for a characteristic you have added to your server is most likely an error.

And with the change in the API it is an error I made (because my methods that were intended didn't have the new extra argument, and I had stupidly not added the override specifier to my declaration, so my methods were quietly sitting there without being used, and the default implementations were used).

It took me a very long time until I found this bug, but if the default callbacks had printed something helpful it would have saved a lot of time.

(Note that I think this feature request holds only for NimbleCharacteristicsCallbacks set and get, because these are the only callbacks where it is probably a programmer error if you don't override them.

@h2zero
Copy link
Owner

h2zero commented Jan 11, 2025

@jackjansen, sorry you had this difficulty. I'm not sure how printing the UUID would have helped, generally speaking if the default callbacks are printing a message that means your callback was not overriding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants