Change jQuery CDN to a China-safe option #1739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW I once tested a few of them and jQuery's (maxcdn) was faster at the time. Although my testing method was rather crude and done 3 years ago. http://stackoverflow.com/a/12981092/881551 |
|
👍 looks good and I assume that the official jQuery source would be the best. |
|
I forgot about this whole discussion. @alrra? (or whoever else has the keys these days...) |
|
@roblarsen Can you also update:
Thanks! |
roblarsen
force-pushed
the
use-jquery-cdn
branch
2 times, most recently
from
6470fbd to
c5638cc
Compare
This commit closes h5bp#1737 In countries where googleapis.com is blocked (China and other countries) H5BP is broken out of the box as jQuery will not load until the request times out. This commit changes the default jQuery source to use the jQuery CDN. The jQuery CDN is as fast or faster (by some reckoning) than the Google Hosted Libraries version and is available worldwide. While the chance of hitting the cache lottery is smaller with the jQuery CDN (it's not as ubiquitous as Google) that chance is not enough to override the need to ship working code for everyone in the world.
roblarsen
force-pushed
the
use-jquery-cdn
branch
from
c5638cc to
87e3b9f
Compare
|
👍 Updated |
|
@roblarsen Thanks! 💜 Merged with some modifications (e.g.: also updated the |
|
👍 |
eleanor-byhook
pushed a commit
to eleanor-byhook/html5-boilerplate
that referenced
this pull request
Feb 29, 2016
In countries where `googleapis.com` is blocked (e.g.: China), HTML5 Boilerplate is broken out of the box as jQuery will not load until the request times out. This commit changes the default jQuery source to use the jQuery CDN as it is as fast or faster (by some reckoning) than the Google Hosted Libraries version and is available worldwide. While the chance of hitting the cache lottery is smaller with the jQuery CDN (it's not as ubiquitous as Google), that chance is not enough to override the need to ship working code for everyone in the world. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix h5bp/html5-boilerplate#1737 Close h5bp/html5-boilerplate#1739
jeffreznik
pushed a commit
to jeffreznik/sw-test
that referenced
this pull request
Oct 15, 2017
In countries where `googleapis.com` is blocked (e.g.: China), HTML5 Boilerplate is broken out of the box as jQuery will not load until the request times out. This commit changes the default jQuery source to use the jQuery CDN as it is as fast or faster (by some reckoning) than the Google Hosted Libraries version and is available worldwide. While the chance of hitting the cache lottery is smaller with the jQuery CDN (it's not as ubiquitous as Google), that chance is not enough to override the need to ship working code for everyone in the world. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix h5bp#1737 Close h5bp#1739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1737
China, with with more web users than there are people in the US, blocks googleaplis.com. We really ought to put the "WORLD" back in World Wide Web with a China-friendly option for jQuery.