Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normalize.css and Optimize head tag order. #3034

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Remove normalize.css and Optimize head tag order. #3034

merged 4 commits into from
Oct 5, 2023

Conversation

rgant
Copy link
Contributor

@rgant rgant commented Oct 4, 2023

Remove normalize.css link. Closes #3033

Optimize header tag order:

How you order elements in the can have an effect on the (perceived) performance of the page.
This script helps you identify which elements are out of order.
https://github.com/rviscomi/capo.js

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

Remove normalize.css link

Optimize header tag order:
> How you order elements in the <head> can have an effect on the (perceived) performance of the page.
> This script helps you identify which elements are out of order.
https://github.com/rviscomi/capo.js
@rgant
Copy link
Contributor Author

rgant commented Oct 4, 2023

I agree to allow the project owners to license my work under the terms of the MIT License.

@coliff
Copy link
Member

coliff commented Oct 4, 2023

looks good - can you please make build so it updates dist/ ?

@rgant
Copy link
Contributor Author

rgant commented Oct 4, 2023

I updated documentation, removing more references to htaccess, normalize.css and main.css which were all removed. Also added instructions for testing and building to the contribution documentation. And updated the dist.

Copy link
Member

@roblarsen roblarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks! It saves a lot of work updating the docs.

package.json Show resolved Hide resolved
@rgant rgant mentioned this pull request Oct 4, 2023
9 tasks
@coliff
Copy link
Member

coliff commented Oct 5, 2023

Great PR - thanks again!

@coliff coliff merged commit 0a9f716 into h5bp:main Oct 5, 2023
6 checks passed
@rgant rgant deleted the patch-1 branch December 28, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize.css still referenced in index.html
3 participants