-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove normalize.css and Optimize head tag order. #3034
Conversation
Remove normalize.css link Optimize header tag order: > How you order elements in the <head> can have an effect on the (perceived) performance of the page. > This script helps you identify which elements are out of order. https://github.com/rviscomi/capo.js
I agree to allow the project owners to license my work under the terms of the MIT License. |
looks good - can you please make build so it updates dist/ ? |
I updated documentation, removing more references to htaccess, normalize.css and main.css which were all removed. Also added instructions for testing and building to the contribution documentation. And updated the dist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks! It saves a lot of work updating the docs.
Great PR - thanks again! |
Remove normalize.css link. Closes #3033
Optimize header tag order:
Types of changes
Checklist:
Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.
Thanks!