Skip to content

Commit

Permalink
Remove the .manifest → text/cache-manifest mapping
Browse files Browse the repository at this point in the history
Four years ago the recommended file extension for AppCache manifest
files was changed¹ from `.manifest` to `.appcache`. So, even adding
into consideration the transitional period, it no longer makes sense
to keep the configurations that ensure that `.manifest` files are
served with the AppCache required `text/cache-manifest` media type.

Also, recently, `.manifest` became one of the recommended file
extensions for web application manifest² files.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

¹ https://html5.org/r/5812
² http://w3c.github.io/manifest/
  • Loading branch information
alrra committed Mar 4, 2015
1 parent 3548b4c commit c805353
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 26 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
### HEAD

* Remove mapping of `.php` files to `text/html`
* Remove the mapping of `.manifest` files to the `text/cache-manifest` media type.
* Remove the mapping of `.php` files to the `text/html` media type
[[daab35b](https://github.com/h5bp/server-configs-apache/commit/daab35bc91c299da23efdfa740f13a46ad10612a)].

### 2.12.0 (March 2, 2015)
Expand Down
2 changes: 1 addition & 1 deletion dist/.htaccess
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ Options -MultiViews
# </Files>

AddType application/x-web-app-manifest+json webapp
AddType text/cache-manifest appcache manifest
AddType text/cache-manifest appcache


# Media files
Expand Down
2 changes: 1 addition & 1 deletion src/media_types/media_types.conf
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
# </Files>

AddType application/x-web-app-manifest+json webapp
AddType text/cache-manifest appcache manifest
AddType text/cache-manifest appcache


# Media files
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/.htaccess
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ Options -MultiViews
# </Files>

AddType application/x-web-app-manifest+json webapp
AddType text/cache-manifest appcache manifest
AddType text/cache-manifest appcache


# Media files
Expand Down
15 changes: 0 additions & 15 deletions test/fixtures/test.manifest

This file was deleted.

7 changes: 0 additions & 7 deletions test/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -287,13 +287,6 @@ exports = module.exports = {
}
},

'test.manifest': {
responseHeaders: {
'cache-control': 'max-age=0, no-transform',
'content-type': 'text/cache-manifest'
}
},

'test.map': {
responseHeaders: {
'cache-control': 'max-age=0, no-transform',
Expand Down

1 comment on commit c805353

@arthurvr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

Please sign in to comment.