Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated curly braces for php7.4 #84

Open
michealmouner opened this issue Apr 16, 2020 · 7 comments
Open

Deprecated curly braces for php7.4 #84

michealmouner opened this issue Apr 16, 2020 · 7 comments

Comments

@michealmouner
Copy link

PHP Deprecated: Array and string offset access syntax with curly braces is deprecated in /h5p-app/vendor/h5p/h5p-core/h5p.classes.php on line 2747

seems fixed on master but it needs to be tagged
@DanielKulbe
Copy link

Yes, a new tag would be nice.

@heddn
Copy link

heddn commented Oct 21, 2020

+1 on a new release.

@marclaporte
Copy link
Contributor

For the record: f6f6d0f

marclaporte referenced this issue Nov 23, 2020
@stronk7
PHP 7.4 fix, don't use curly braces for array/string offset
f6f6d0f 
The array and string offset access syntax using curly braces is deprecated.
Use $str[$idx] instead of $str{$idx}.
RFC: https://wiki.php.net/rfc/deprecate_curly_braces_array_access
@esseremmerik
Copy link

We need a new release with this fix

@SebastiaanKloos
Copy link

Can somebody please create the new tag?

@TamasSzigeti
Copy link

bump

@jonnybradley
Copy link

I'm trying to get h5p to run on php8 so this curly braces issue fix was needed as that's now a fatal error, but now i'm getting over a dozen warnings about Required parameter $varname follows optional parameter - is anyone working on this, and/or should i create a new separate issue about this and php8?
TIA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@jonnybradley @TamasSzigeti @marclaporte @heddn @DanielKulbe @michealmouner @esseremmerik @SebastiaanKloos