-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sinc filter does not work with videos #248
Comments
Can you provide the same source frame you used, as a reference? Avisynth is using four taps for Sinc, whereas libplacebo uses three taps however, that is unlikely to cause the difference. |
Cannot replicate the output with libplacebo e987124 and ffmpeg master ab2173c0a5.
|
Yeah weird. That works. But this code |
Here, try this 30 seconds snippet. And this time, encode it as video. Edit: My guess is it only works with RGB inputs, and YUV fails. Pure speculation. Can't test right now. |
fixed in 76bb971 |
Command used to test:
ffmpeg -y -benchmark -init_hw_device vulkan -i "input" -vf "libplacebo=w=iw*2:h=ih*2:upscaler=sinc" -c:v libx264 -preset ultrafast -qp 0 -g 1 -an test123.mkv
Some comparisons:
Spline36 (Avisynth)
Sinc (Avisynth) How it is supposed to look
Bilinear (Avisynth)
Sinc (libplacebo) Looks blurrier then Bilinear
The same thing happens with gpu-next in MPV: mpv-player/mpv#13672
The text was updated successfully, but these errors were encountered: