Check what needs to be upgraded for client-go v6

[asymmetric]

There are some changes to be made. Off the top of my head:

• v1 instead of v1beta1 for Deployments
• getting rid of newListWatchFromClientWithLabels and use NewFilteredSharedInformerFactory.

[lilic]

I do not understand this issue, we are already at client-go v6.0.0?

[asymmetric]

Yes, but we haven't performed the changes in our codebase that can/should go along with it.

[lilic]

Yes, those are nice to have, but not necessary to have things working. As deployments is supported for at least 1.9.x, maybe even more. This way we do not break compatibility with older k8s versions.

getting rid of newListWatchFromClientWithLabels

Why is this needed?

[asymmetric]

That's a good point about compatibility. But at some point we have to update (v1beta1.Deployment will be deprecated and then removed at some point, I presume), and this issue can be useful to list what we need to do.

I edited my post above to answer your second point.

[lilic]

(v1beta1.Deployment will be deprecated and then removed at some point, I presume)

There is ongoing discussion upstream to not deprecate versions as fast as it is currently, we will see what comes out of that.