Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark key as done only if it is #222

Closed
asymmetric opened this issue Mar 27, 2018 · 0 comments · Fixed by #274
Closed

Mark key as done only if it is #222

asymmetric opened this issue Mar 27, 2018 · 0 comments · Fixed by #274
Labels

Comments

@asymmetric
Copy link
Contributor

We currently mark a key as done even if there have been problems handling it.
This is because the defer gets called even in case of error.

This is probably the cause of #153.

We should wrap the key handling code so that key marking only happens when there are no errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant