Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a per PR test run using CI #324

Open
surajssd opened this issue Aug 2, 2018 · 2 comments
Open

Setup a per PR test run using CI #324

surajssd opened this issue Aug 2, 2018 · 2 comments

Comments

@surajssd
Copy link
Contributor

surajssd commented Aug 2, 2018

RIght now there is no CI that runs with each PR. We should have a setup where each PR triggers a test run.

Proposal:

We can have a single node k8s setup on Semaphore CI, which runs as following:

  • Option 1: use minikube with vm-driver none.
  • Option 2: use kubeadm to start the master and then allow it to schedule pods.
@krnowak
Copy link
Contributor

krnowak commented Aug 2, 2018

RIght now there is no CI that runs with each PR. We should have a setup where each PR triggers a test run.

We have it, it runs the tests on GKE through circle ci. But this would need contributors to set up their own GKE instance to have their PR tested, which can be a PITA.

So maybe something based on minikube on some other CI (or maybe even the same) wouldn't be a bad idea, especially if that would allow us to run the tests locally.

I haven't had a look at how it is being done currently, though, so I don't know the details.

@kosyfrances
Copy link
Contributor

kosyfrances commented Aug 2, 2018

@surajssd Here is the commit showing the changes we made to migrate the tests from running on Minikube to running successfully on GKE. Notice we had to change the bind-config service type from NodePort to LoadBalancer here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants