-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow packages to expose a runnable hook #5161
Comments
This would be an excellent addition. Currently, in our windows packages we are able to handle installs of .net framework, legacy IBM drivers, windows services, etc via DSC. We are able to wrap the installers in hab packages to guarantee they are there at runtime, however the DSC has to be reproduced and maintained in each and every package/service that depends on the above items. It would be much nicer if the packages containing the installers had a hook like described above so they could be used in a modular fashion. |
Its worth referencing the discussion in https://forums.habitat.sh/t/service-paths-config-without-service/643 here as well. @themightychris brings up a scenario of library packages that will never be run as a service. They are command wrappers but still need some configuration performed around templates to reference service paths. One thought there is that we might consider introducing a |
This is in progress in the following PRs: Adds behavior to execute a new The |
@mwrock this is awesome work, I love the approach so far! How are you envisioning config being input for templating in lieu of being able to target a supervisor with |
@themightychris it will honor a |
@mwrock excellent! It would be a cool bonus if there were a |
yeah that would be a nice addition but perhaps left to a separate PR. One thing to be clear about is that the |
@mwrock it does! |
closed by #5866 |
On Windows (and maybe Linux too?) there are some legacy scenarios where a dependency package may need to apply some setup script on the supervisor node before it can be used. Examples are:
The idea here is that a "service" package could declare a dependency on such a package as listed above and the supervisor would call its hook during (or before) the
init
phase.We currently handle this scenario by performing all the setup of the deps in the service's
init
hook but that makes the dep very much coupled to the service.The text was updated successfully, but these errors were encountered: