Apply Connection/Identity refactor #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
possible further refactor of agent api: break down the agent class into connection(endpoint+identity). might remain for agent 3.0, might be needed sooner to untangle the current authentication flow
flatten connection and deployment namespaces
not as far back as it looks
- step back, two forward - got to the point where I sort out various types of signers: - from mnemonic (variant from genesis account) - from keplr (variant auto add chain to keplr) - from keystore (node only, shell out to secretd tx sign)
+coverage(64.47%), +typechecks(29)
+66.68% total coverage
+23 type checks
+43 s to run pnpm cov all
+churnin'!
- move the Logged class to @hackbg/logs
- better log labeling across the bord
- add missing methods to native token types
- split modules cw-base/cw-connection/cw-identity
- same for scrt: add ScrtSignerIdentity, ScrtMnemonicIdentity
- remove OKP4Config, ScrtConfig environment config api for now
- not happy about how ts/tsdoc handle renamed exports
- can't `import type Foo, { Bar } from './baz'` - ridiculous
- construct new identity objects correctly for devnet
- ghost devnets now cause bug, time for that signal-exit package
- per-chain id node and faucet lists
- rethrow thrown non-Error object from secretjs rpc as Error
so that it gets displayed normally, othersize:
"program died because: [#<Object>]"
- 71.22% total coverage - mainly because @fadroma/scrt is at 46.68% - which is mainly because of mocknet - which needs to be rewritten on top of the new Stub.Connection and Stub.Backend in @fadroma/agent - which would be halfway to non-scrt mocknets (the other half is "just" cosmwasm-in-wasm) - 18 type checks - more line breaks in log messages - more non-Error catches - make decodeError in @fadroma/scrt public - remove OKP4-config, too, and set correct chain id
missing method needed by dashboard
- just the project creation tool - publishing to this NPM package id should enable 'npx fadroma create' instead of 'npx @hackbg/fadroma@latest create'
- 2 type checks left in devnet (when passing around Connection subclasses) - 36 type checks total
tests fail due to some relative path issue, will fixt
- cw, scrt and evm dirs now at top level of repo - @hackbg/fadroma takes over hub duties from @fadroma/connect now that services (create, build, devnet) are separate packages - improved separation of concern - fewer version numbers to update manually when releasing (TODO auto) - 24 type checks - 70.24% coverage
- remove getDevnetFromEnvironment
- reexport ProjectPrompter from from @fadroma/compile
- fix gas type in CWConnection
- fix batch types ('as unknown as' blech)
- Scrt/OKP4Contract.versions->.version
- Secret Network mocknet (in @fadroma/scrt) is now special case of stub chain (in @fadroma/agent) - with some CosmWasm-to-builtin-WASM glue added to enable contract binaries to be executed off-chain - need to build appropriate fixture for the tests to pass - type checks pass
- update @hackbg/ubik 2.0.8 - update vendored platform sdks with latest ubik - update @hackbg/cmds 3.1 - bump version numbers, let's do a release of the core connectivity package then focus on the services (create, build, devnet)
still need to build a working fixture
Address, Label, Message, TxHash
- remove couple of redundant deps/reexports - Decimal -> Decimal128 to match the rest
- testChainSupport -> testConnectionWithBackend
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded core with parallel Secret Network and CosmJS Stargate support.
Passes tests.
1.0.0-rc.1of@fadroma/compile,@fadroma/devnets,@fadroma/create