Impl profile update #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commited a fix for #11 @elf-pavlik please, kindly review and merge PR if appropiate |
|
pinging @elf-pavlik Or should I try to review it? Btw., we could try to squash commits before pushing. |
|
@acorbi update should use PUT not POST! I'll try to modify it... |
|
i added DELETE in c630610, lets discuss update directly in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
The POST / method has been modified in order to check if a profile is already listed. In that case, overrides the existing file in the data folder. If not, creates a new one.
@elf-pavlik please kindly review, merge and pull on http://profiles.allmende.io/directory