Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling #10

Open
seanjparker opened this issue Sep 15, 2019 · 0 comments
Open

Improved error handling #10

seanjparker opened this issue Sep 15, 2019 · 0 comments
Labels
feature New feature or request nice-to-have

Comments

@seanjparker
Copy link
Collaborator

seanjparker commented Sep 15, 2019

The error handling in hs_applications is very basic right now. We don't have a 404 page and the ApiErrors are chosen using a switch statement which could be made much cleaner using a map (see here)

Also, we should define some proper error codes since we just throw errors which messages so replacing this with an Enum would be a nice addition. Another nice feature would be wrapping errors, currently when an error occurs in a async function the original error message is dropped.

@seanjparker seanjparker added feature New feature or request low priority labels Sep 15, 2019
@seanjparker seanjparker self-assigned this Aug 28, 2020
@seanjparker seanjparker removed the P3 label Oct 27, 2020
@seanjparker seanjparker removed their assignment Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request nice-to-have
Projects
None yet
Development

No branches or pull requests

1 participant