Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Information component #683

Open
Tracked by #708
erikguntner opened this issue Apr 24, 2024 · 0 comments · May be fixed by #753
Open
Tracked by #708

Contact Information component #683

erikguntner opened this issue Apr 24, 2024 · 0 comments · May be fixed by #753
Assignees
Labels
Complexity: Small Issue has detailed instructions to resolve and the task is simple. enhancement New feature or request p-Feature: Profile Guest points: 2 Can be done in 7-12 hours Role: Front End

Comments

@erikguntner
Copy link
Collaborator

erikguntner commented Apr 24, 2024

Overview

We need to finalize the Contact Information component.

For this, you will have to work off the feat/generated-profile branch.

Screenshot 2024-04-23 at 6 09 01 PM

The trickiest part of this is the validation of the "What is the best way to contact you question?". The user can only select email if the email field is filled in and valid and the user can only select phone if the phone field is filled in and valid. I think there are a few ways we can approach this:

  1. We can make the contact information section a component with a custom validation schema for it.
  2. We can render the email and phone number fields like we normally would make the radio group a component and use the values from the email and phone number fields to do some custom validation.
  3. Another way I'm not currently seeing. Always open to suggestions and whoever takes this can play around with a different approach.

Action Items

The action items will depend on the approach you decide to take to complete this task.

Resources/Instructions

https://www.figma.com/file/BNWqZk8SHKbtN1nw8BB7VM/HUU-Everything-Figma-Nov-2022?type=design&node-id=11664-68090&mode=design&t=IekRfD8VxWN7bKYK-4

@erikguntner erikguntner added enhancement New feature or request Role: Front End p-Feature: Profile Guest points: 2 Can be done in 7-12 hours labels Apr 24, 2024
@erikguntner erikguntner added this to the 6- MVP milestone Apr 24, 2024
@johnwroge johnwroge self-assigned this May 2, 2024
@erikguntner erikguntner added the Complexity: Small Issue has detailed instructions to resolve and the task is simple. label Aug 14, 2024
@johnwroge johnwroge linked a pull request Aug 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Issue has detailed instructions to resolve and the task is simple. enhancement New feature or request p-Feature: Profile Guest points: 2 Can be done in 7-12 hours Role: Front End
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants