Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Review file tree and update MUI Components #1617

Open
13 of 43 tasks
Tracked by #1611
JackHaeg opened this issue Mar 26, 2024 · 4 comments
Open
13 of 43 tasks
Tracked by #1611

Epic: Review file tree and update MUI Components #1617

JackHaeg opened this issue Mar 26, 2024 · 4 comments
Labels
Epic/Overview Contains a list of other issues or an overview of issue feature: refactor to MUI ready for dev lead Add to issue when dev lead needs to take some action role: Front End size: 8pt Can be done in 31-48 hours

Comments

@JackHaeg
Copy link
Member

JackHaeg commented Mar 26, 2024

Overview

Currently, components throughout the VRMS app do not match - some use MUI styling while others do not, thus creating a fractured user experience. All components throughout the VRMS file tree below must be updated to Material-UI components.

What if we're unable to access the component listed

Do your best to change the HTML elements out anyway and note in the PR that you're unable to get the component to render within VRMS for screenshots.

Should I try to match the CSS of the app beforehand

No, there will be some changes to the look and feel of the app switching to MUI components, we plan on going back in a second set of issues to match the CSS to our current figma design or a new figma design as it comes available.

Action Items

Check off these items when we have fully moved from standard HTML components to MUI components (note that same may already be updated to MUI). Each can be broken into its own issue.

Resources/Instructions

https://mui.com/base-ui/all-components/

@JackHaeg JackHaeg added this to the 04.01 Existing Features milestone Mar 26, 2024
@JackHaeg JackHaeg changed the title Grab file tree of components and check if components are updated to MUI components. Create file tree for MUI Components Mar 26, 2024
@JackHaeg JackHaeg added draft Not ready for prioritization yet ready for dev lead Add to issue when dev lead needs to take some action labels Mar 26, 2024
@trillium
Copy link
Member

trillium commented Apr 9, 2024

#1549 has a list of all the files with jsx

./src/components/ProjectForm.js
./src/components/Navbar.js
./src/components/auth/Auth.js
./src/components/auth/HandleAuth.js
./src/components/user-admin/EditUsers.js
./src/components/user-admin/AddNewProject.js
./src/components/user-admin/UserManagement.js
./src/components/admin/donutChartContainer.js
./src/components/admin/donutChartLoading.js
./src/components/admin/dashboard/index.js
./src/components/admin/donutChart.js
./src/components/admin/reports/index.js
./src/components/dashboard/AddTeamMember.js
./src/components/dashboard/RosterTable.js
./src/components/dashboard/RosterTableRow.js
./src/components/presentational/CheckInButtons.js
./src/components/presentational/returnUserForm.js
./src/components/presentational/newUserForm.js
./src/components/presentational/profile/UserTable.js
./src/components/presentational/upcomingEvent.js
./src/components/manageProjects/eventForm.js
./src/components/manageProjects/editableField.js
./src/components/manageProjects/editMeetingTimes.js
./src/components/manageProjects/editProject.js
./src/components/manageProjects/addProject.js
./src/components/parts/form/ValidatedTextField.js
./src/components/parts/boxes/TitledBox.js
./src/components/Form.js
./src/components/Leaderboard.test.js
./src/components/Footer.js
./src/pages/Events.js
./src/pages/CheckInForm.js
./src/pages/ProjectLeaderDashboard.js
./src/pages/UserAdmin.js
./src/pages/UserProfile.js
./src/pages/ReturningUser.js
./src/pages/Home.js
./src/pages/ProjectList.js
./src/pages/ManageProjects.js
./src/pages/NewUser.js
./src/pages/SecretPassword.js
./src/App.js

@trillium
Copy link
Member

trillium commented Aug 6, 2024

Hey all, @chukalicious was asking what we should do for components that aren't being used and aren't accessible if they're in this MUI update list.

We should close those issues as unplanned and mark in the list after the issue number that the component isn't used in the current iteration of the app.

eg

And inside that issue mark it as unplanned

@JackHaeg
Copy link
Member Author

JackHaeg commented Aug 7, 2024

@trillium Can you please close issues containing components that are not being used, add text: [ closed, unused component ] next to these issues, and make an update to this issue within the section "What if we're unable to access the component listed."

@trillium
Copy link
Member

trillium commented Aug 8, 2024

@JackHaeg Done :)

@JackHaeg JackHaeg added the Epic/Overview Contains a list of other issues or an overview of issue label Aug 8, 2024
@JackHaeg JackHaeg changed the title Review file tree and update MUI Components Epic: Review file tree and update MUI Components Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic/Overview Contains a list of other issues or an overview of issue feature: refactor to MUI ready for dev lead Add to issue when dev lead needs to take some action role: Front End size: 8pt Can be done in 31-48 hours
Projects
Status: Epic Issues
Development

No branches or pull requests

3 participants