Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On admin login page, make error state " " to prevent layout shift #1645

Closed
1 task done
trillium opened this issue May 29, 2024 · 0 comments · Fixed by #1676
Closed
1 task done

On admin login page, make error state " " to prevent layout shift #1645

trillium opened this issue May 29, 2024 · 0 comments · Fixed by #1676
Assignees
Labels
Milestone

Comments

@trillium
Copy link
Member

trillium commented May 29, 2024

Overview

When the user encounters an error in the /admin page on the email field, the buttons are bumped down to display the error state

image

We can prevent this by rendering a space in in the error state

Action Items

  • Render a space in the error state to ensure that the buttons below the email field don't get bumped down.
@trillium trillium added role: Front End size: 0.5pt Can be done in 2-3 hours or less labels May 29, 2024
@trillium trillium added this to the 04.05 Login milestone May 29, 2024
@JackHaeg JackHaeg changed the title On admin long in page, make error state " " to prevent layout shift On admin login page, make error state " " to prevent layout shift May 30, 2024
@angela-lee1 angela-lee1 self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants