Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find icon author #2169

Closed
5 tasks done
ExperimentsInHonesty opened this issue Aug 23, 2021 · 4 comments
Closed
5 tasks done

Find icon author #2169

ExperimentsInHonesty opened this issue Aug 23, 2021 · 4 comments
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ P-Feature: Credit https://www.hackforla.org/credits/ role: design size: missing
Milestone
01. Compliance

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Aug 23, 2021 •
edited by ahoang94
Loading

Overview

We need make sure the icons on the Credit page are correctly listing which images we are using on the site, where they are used and where they came from.

Action Items

  • Please find the hand and heart image next to Giving on the about page under platform and add the details to the Figma for the credit file and provide details for development:
    • Name:
    • Used in: About
    • Artist:
    • Provider

Resources/Instructions

In the past this image was improperly conflated with a similar hand image - see Prior PR #2093
Figma-credits page
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 23, 2021
Closed
1 task
@ExperimentsInHonesty ExperimentsInHonesty added P-Feature: Credit https://www.hackforla.org/credits/ P-Feature: About Us https://www.hackforla.org/about/ role: design Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 23, 2021
@ExperimentsInHonesty ExperimentsInHonesty added this to the 01. Compliance milestone Aug 23, 2021
@ahoang94
Copy link
Member

ahoang94 commented Aug 25, 2021 •
edited
Loading

@kristine-eudey The correct icon author has been sourced and the information has been added to the Figma file.

Screen Shot 2021-08-24 at 9 46 43 PM

@kristine-eudey
Copy link
Member

@ahoang94 thanks! The design portion of this issue has been completed.

@kristine-eudey
Copy link
Member

@abuna1985 design portion of this issue is complete, please make development issue. Thank you!

@kristine-eudey kristine-eudey added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 28, 2021
@abuna1985
Copy link
Member

@kristine-eudey #2356 has been created to add an icon to the Credits page. Moving this issue to the Done column

@abuna1985 abuna1985 removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ P-Feature: Credit https://www.hackforla.org/credits/ role: design size: missing
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
01. Compliance
Development

No branches or pull requests
6 participants
@kristine-eudey @abuna1985 @ExperimentsInHonesty @kevngaleu @ahoang94 @Josiah-O