Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run VSCode Spell Checker on _includes/donate-card.html #5531

Closed
6 of 9 tasks
Tracked by #5248
roslynwythe opened this issue Sep 15, 2023 · 6 comments
Closed
6 of 9 tasks
Tracked by #5248

Run VSCode Spell Checker on _includes/donate-card.html #5531

roslynwythe opened this issue Sep 15, 2023 · 6 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Sep 15, 2023

Overview

We need to audit HfLA codebase files for spelling errors using the VSCode Code Spell Checker extension in order to ensure site quality. Results will be categorized as misspellings, false positives in the HfLA spelling audit spreadsheet1 and will be resolved in later issues.

Action Items

  • You must use VS Code as your local text editor and install the Code Spell Checker VS Code extension2
  • Do not change any configuration settings or make any spell corrections
  • Open the file '_includes/donate-card.html'and note any Code Spell Checker errors
  • Locate the file in column A ("File") of the "Page Audit" sheet. In the column labelled "Result Summary", select the appropriate option: No errors or At least one error.
  • If at least one error was reported, copy/paste each cSpell message into a separate row in the Results sheet
  • In each new row, select the appropriate value: misspelling or false positive from the "Result type" column. A false positive is a term that is not a misspelling, but it is not recognized by the spell checker because it is a technical term, abbreviation, acronym, URL or proper noun (name of a person, place or organization).
  • Move this issue to the Questions/In Review column and apply the label 'ready for dev lead`

Merge Team

Resources/Instructions

Footnotes

  1. HfLA spelling audit spreadsheet - Results

  2. The recommended installation method is to install Code Spell Checker directly from the VS Code text editor, and those instructions can be found here. The extension can also be installed via the VS Code Marketplace website here.

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 15, 2023
@github-actions
Copy link

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 15, 2023
@roslynwythe roslynwythe added this to the x. Technical debt milestone Sep 15, 2023
@roslynwythe roslynwythe added the size: 0.5pt Can be done in 3 hours or less label Sep 15, 2023
@kezzaam kezzaam self-assigned this Sep 15, 2023
@github-actions
Copy link

Hi @kezzaam, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@kezzaam
Copy link
Member

kezzaam commented Sep 15, 2023

Availability: Sunday-Thursday around an hour each day - I have flexible working hours.
ETA: Wednesday 20th September - 11pm PST

@kezzaam kezzaam added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 20, 2023
@kezzaam
Copy link
Member

kezzaam commented Sep 20, 2023

I ran the spell checker on _includes/donate-card.html and there were no errors found.
I have updated the spreadsheet to reflect this.

@kezzaam
Copy link
Member

kezzaam commented Oct 1, 2023

Status: waiting on dev lead to check this issue

@kezzaam kezzaam added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Oct 1, 2023
@LRenDO
Copy link
Member

LRenDO commented Oct 4, 2023

Hi @kezzaam! Great job with this issue! It looks like there are no errors on this page on my end too! You also did a great job with moving the issue to the right column and adding the correct label. Thanks for contributing to this epic!

@LRenDO LRenDO closed this as completed Oct 4, 2023
@LRenDO LRenDO removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 4, 2023
@ExperimentsInHonesty ExperimentsInHonesty added feature: spelling and removed Feature: Administrative Administrative chores etc. labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Archived in project
Development

No branches or pull requests

4 participants