Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run VS Code Spell Checker on _includes/events-page/right-col-content.html #5594

Closed
8 of 9 tasks
Tracked by #5248
roslynwythe opened this issue Sep 26, 2023 · 5 comments
Closed
8 of 9 tasks
Tracked by #5248
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Sep 26, 2023

Overview

We need to audit HfLA codebase files for spelling errors using the Code Spell Checker extension in VS Code in order to ensure site quality. Results will be categorized as misspellings or false positives in the HfLA spelling audit spreadsheet1 and will be resolved in later issues.

Action Items

  • You must use VS Code as your local text editor and install the Code Spell Checker VS Code extension2
  • Do not change any configuration settings or make any spell corrections
  • Open the file '_includes/events-page/right-col-content.html' and note any Code Spell Checker errors
  • Locate the file in column A ("File") of the "Page Audit" sheet. In the column labeled "Result Summary", select the appropriate option: No errors or At least one error.
  • If at least one error was reported, copy/paste each cSpell message into a separate row in the Results sheet
  • In each new row, select the appropriate value: misspelling or false positive from the "Result type" column. A false positive is a term that is not a misspelling but is not recognized by the spell checker because it is a technical term, abbreviation, acronym, URL or proper noun (name of a person, place or organization).
  • Move this issue to the Questions/In Review column and apply the label ready for dev lead

Merge Team

Resources/Instructions

Footnotes

  1. HfLA spelling audit spreadsheet - Results

  2. The recommended installation method is to install Code Spell Checker directly from the VS Code text editor, and those instructions can be found here. The extension can also be installed via the VS Code Marketplace website here.

@roslynwythe roslynwythe added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Sep 26, 2023
@roslynwythe roslynwythe added this to the x. Technical debt milestone Sep 26, 2023
@A-Wu5 A-Wu5 self-assigned this Sep 27, 2023
@github-actions
Copy link

Hi @A-Wu5, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@A-Wu5
Copy link
Member

A-Wu5 commented Sep 27, 2023

i. Availability: M-F Evening
ii. ETA: By Friday evening

@A-Wu5 A-Wu5 added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 3, 2023
@LRenDO
Copy link
Member

LRenDO commented Oct 4, 2023

Hi @A-Wu5! You also did a great job with moving the issue to the right column and adding the correct label! It looks like there were no errors. However, that is not listed in the Results tab of the spreadsheet next to _includes/events-page/right-col-content.html

  • On the Results tab of the spreadsheet in the Result Summary column of the _includes/events-page/right-col-content.html row, please update to No Errors.

Once it's completed, you can ping me here in a comment to let me know and add the ready for dev lead tag back to the issue. Thanks for working on this issue!

@LRenDO LRenDO removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 4, 2023
@A-Wu5
Copy link
Member

A-Wu5 commented Oct 7, 2023

Hey @LRenDO! Thanks for pointing that out. I want to mention that in the File column of the Page Audit tab, there are two entries (row 20 and row 136) that are _includes/events-page/right-col-content.html. I initially marked the 2nd one to No Errors and I did not realize there was another same entry. Currently, both are marked as No Errors. I am not sure if this is okay.

@LRenDO
Copy link
Member

LRenDO commented Oct 8, 2023

Hi @A-Wu5! Looks great! Thanks for bringing it to our attention that there were two instances! Great work and thanks again for working on the issue!

@LRenDO LRenDO closed this as completed Oct 8, 2023
@ExperimentsInHonesty ExperimentsInHonesty added feature: spelling and removed Feature: Administrative Administrative chores etc. labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Archived in project
Development

No branches or pull requests

4 participants