Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run VS Code Spell Checker on _data/internal/communities/ops.yml #6095

Closed
8 of 9 tasks
Tracked by #5248
roslynwythe opened this issue Jan 10, 2024 · 5 comments
Closed
8 of 9 tasks
Tracked by #5248

Run VS Code Spell Checker on _data/internal/communities/ops.yml #6095

roslynwythe opened this issue Jan 10, 2024 · 5 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Jan 10, 2024

Overview

We need to audit HfLA codebase files for spelling errors using the Code Spell Checker extension in VS Code in order to ensure site quality. Results will be categorized as misspellings or false positives in the HfLA spelling audit spreadsheet1 and will be resolved in later issues.

Action Items

  • You must use VS Code as your local text editor and install the Code Spell Checker VS Code extension2
  • Do not change any configuration settings or make any spell corrections
  • Open the file '_data/internal/communities/ops.yml' and note any Code Spell Checker errors
  • Locate the file in column A ("File") of the "Page Audit" sheet. In the column labeled "Result Summary", select the appropriate option: No errors or At least one error.
  • If at least one error was reported, copy/paste each cSpell message into a separate row in the Results sheet
  • In each new row, select the appropriate value: misspelling or false positive from the "Result type" column. A false positive is a term that is not a misspelling but is not recognized by the spell checker because it is a technical term, abbreviation, acronym, URL or proper noun (name of a person, place or organization).
  • Move this issue to the Questions/In Review column and apply the label ready for dev lead

Merge Team

Resources/Instructions

Footnotes

  1. HfLA spelling audit spreadsheet - Results

  2. The recommended installation method is to install Code Spell Checker directly from the VS Code text editor, and those instructions can be found here. The extension can also be installed via the VS Code Marketplace website here. For developers who do not use VS Code, use the corresponding npm package, cspell. Those instructions can be found at https://www.npmjs.com/package/cspell

@roslynwythe roslynwythe added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.5pt Can be done in 3 hours or less feature: spelling and removed Feature: Administrative Administrative chores etc. ready for dev lead Issues that tech leads or merge team members need to follow up on labels Jan 10, 2024
@roslynwythe roslynwythe added this to the x. Technical debt milestone Jan 10, 2024
@github-actions github-actions bot added Feature: Administrative Administrative chores etc. ready for dev lead Issues that tech leads or merge team members need to follow up on and removed feature: spelling labels Jan 10, 2024
@roslynwythe roslynwythe added feature: spelling and removed Feature: Administrative Administrative chores etc. ready for dev lead Issues that tech leads or merge team members need to follow up on labels Jan 10, 2024
@das-mittel das-mittel self-assigned this Mar 12, 2024
Copy link

Hi @das-mittel, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@das-mittel
Copy link
Member

i. Available to work on this issue every 2 days until estimated completion date
ii. Expected to have this issue completed by March 21; first progress update to be issued at minimum by March 16

@das-mittel das-mittel added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 13, 2024
@LRenDO
Copy link
Member

LRenDO commented Mar 20, 2024

Hi @das-mittel! Great job moving this issue to the correct column and adding the correct label. On my end I am seeing 6 errors and they are different from the error that you added. I believe this is because your local gh-pages is behind Hack for LA's. Please make sure you've pulled the current upstream gh-pages and add update the results page on the spreadsheet. When you're finished, you can move the issue back to the Questions / In Review column and add the ready for dev lead label. Thank you for working on this issue!

@LRenDO LRenDO removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 20, 2024
@das-mittel
Copy link
Member

Hi @das-mittel! Great job moving this issue to the correct column and adding the correct label. On my end I am seeing 6 errors and they are different from the error that you added. I believe this is because your local gh-pages is behind Hack for LA's. Please make sure you've pulled the current upstream gh-pages and add update the results page on the spreadsheet. When you're finished, you can move the issue back to the Questions / In Review column and add the ready for dev lead label. Thank you for working on this issue!

Thank you very much for reviewing the issue! I will look over the results once more and resubmit upon completion

i. Available to work on this issue every 2 days until estimated completion date
ii. Expected to have this issue completed by March 27

@das-mittel das-mittel added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 28, 2024
@LRenDO
Copy link
Member

LRenDO commented Apr 4, 2024

Hi @das-mittel! Great job with this issue! It looks like the same errors on this page are on my end too! You also did a great job with moving the issue to the right column and adding the correct label. Thanks for contributing to this epic!

@LRenDO LRenDO closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

3 participants