Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run VS Code Spell Checker on .github/ISSUE_TEMPLATE/img-tag-refactor.md #6487

Closed
7 of 9 tasks
Tracked by #5248
roslynwythe opened this issue Mar 21, 2024 · 5 comments
Closed
7 of 9 tasks
Tracked by #5248
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Mar 21, 2024

Overview

We need to audit HfLA codebase files for spelling errors using the Code Spell Checker extension in VS Code in order to ensure site quality. Results will be categorized as misspellings or false positives in the HfLA spelling audit spreadsheet1 and will be resolved in later issues.

Action Items

  • You must use VS Code as your local text editor and install the Code Spell Checker VS Code extension2
  • Do not change any configuration settings or make any spell corrections
  • Open the file '.github/ISSUE_TEMPLATE/img-tag-refactor.md' and note any Code Spell Checker errors
  • Locate the file in column A ("File") of the "Page Audit" sheet. In the column labeled "Result Summary", select the appropriate option: No errors or At least one error.
  • If at least one error was reported, copy/paste each cSpell message into a separate row in the Results sheet
  • In each new row, select the appropriate value: misspelling or false positive from the "Result type" column. A false positive is a term that is not a misspelling but is not recognized by the spell checker because it is a technical term, abbreviation, acronym, URL or proper noun (name of a person, place or organization).
  • Move this issue to the Questions/In Review column and apply the label ready for dev lead

Merge Team

Resources/Instructions

Footnotes

  1. HfLA spelling audit spreadsheet - Results

  2. The recommended installation method is to install Code Spell Checker directly from the VS Code text editor, and those instructions can be found here. The extension can also be installed via the VS Code Marketplace website here.

@roslynwythe roslynwythe added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.5pt Can be done in 3 hours or less Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Mar 21, 2024
@roslynwythe roslynwythe added this to the x. Technical debt milestone Mar 21, 2024
@aswutmaxcy aswutmaxcy self-assigned this Mar 21, 2024
Copy link

Hi @aswutmaxcy, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@aswutmaxcy
Copy link
Member

Hello,

I'll be available 8-4 EST M-F and should be done with this EoD 3/21/24.
Will update if ETA needs to be updated.

@aswutmaxcy
Copy link
Member

I couldn't get the code spell checker to work on some files, it seemed to only work on certain directories, others it seemed to ignore. I'm not 100% on which ones it's ignoring or not.

I'm using the extension on VScode on win11, I tried using it on remote WSL connection as well with the same results.

How do I get code spell checker to run on the file above? ('.github/ISSUE_TEMPLATE/img-tag-refactor.md)

@aswutmaxcy
Copy link
Member

an update to my previous comment:

I removed ln 20 ".github" in the file cspell.json temporarily to let Code Spell Checker spell check the file img-tag-refactor-on-website.md

After which I found no errors and added the line back, updated my local repo, didn't push or commit, and updated the audit excel sheet.

@aswutmaxcy aswutmaxcy added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 22, 2024
@roslynwythe
Copy link
Member Author

roslynwythe commented Mar 28, 2024

Thank you @aswutmaxcy, you are absolutely correct and it would not be possible to spell check that markdown template without the process you describe. I do apologize for the confusion and I will clarify that in any future issues that audit spelling on templates within the .github folder. Thank you for noting your results in the spreadsheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

3 participants