Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofeaturizer needs ability to use custom column names #148

Closed
ardunn opened this issue Dec 11, 2018 · 0 comments
Closed

Autofeaturizer needs ability to use custom column names #148

ardunn opened this issue Dec 11, 2018 · 0 comments
Assignees

Comments

@ardunn
Copy link
Contributor

ardunn commented Dec 11, 2018

Autofeaturizer should have the ability to use custom column names. "structure" and "composition" should not be hardcoded in as they are now.

The autofeaturizer init method should accept either two arguments, one for identifying the composition column and one for identifying the structure column:

__init__(...composition_col="composition", structure_col="structure"...)

or a single dict argument named colmap (or similar) which maps multiple columns onto their featurization arguments:

colmap={"structure": "MyStructure", "composition": "MyComposition"}

This should also be done for bandstructure and dos, although they are less important

@ardunn ardunn added the ugrads label Dec 11, 2018
@ADA110 ADA110 self-assigned this Dec 11, 2018
@ardunn ardunn closed this as completed Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants