Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metaselector needs a rework #149

Closed
ardunn opened this issue Dec 11, 2018 · 3 comments
Closed

Metaselector needs a rework #149

ardunn opened this issue Dec 11, 2018 · 3 comments
Assignees
@Qi-max

Comments

@ardunn
Copy link
Contributor

ardunn commented Dec 11, 2018

Metaselector has the following problems:

  • It is not robust to problems with compositions/structures in the input dataframe (i.e., one np.nan in the composition column will error an entire matpipe)
  • It should be based on doing featurizer.precheck(df) by implementing a precheck method in every featurizer in matminer

Undergrads, if you are interested in this one, @ me or @Qi-max for the best way to do this, and it will probably take a little while to do right
@ardunn ardunn added the ugrads label Dec 11, 2018
@ardunn
Copy link
Contributor Author

ardunn commented Dec 12, 2018

@Qi-max I temporarily disabled metaselector by default until this is fixed

@ardunn
Copy link
Contributor Author

ardunn commented Dec 12, 2018

new metaselector will also need a test just for making sure no errors happen when composition/structure/bs/dos cols have an erroneous value

@ardunn ardunn assigned albalu and Qi-max and unassigned albalu Jan 26, 2019
@ardunn
Copy link
Contributor Author

ardunn commented Apr 1, 2019

Done via hackingmaterials/matminer#384

@ardunn ardunn closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Qi-max Qi-max

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@albalu @ardunn @Qi-max