Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize preprocess for the future use of pipeline #20

Closed
Qi-max opened this issue May 31, 2018 · 3 comments
Closed

normalize preprocess for the future use of pipeline #20

Qi-max opened this issue May 31, 2018 · 3 comments

Comments

@Qi-max
Copy link
Contributor

Qi-max commented May 31, 2018

For the future use of pipeline, the classes in matbench.preprocess can also take the form of fit + transform, as the classes insklearn.preprocessing, such as Imputer and LabelEncoder etc.

@ardunn
Copy link
Contributor

ardunn commented May 31, 2018

If this is the case, similarly, AutoSKLearn class should implement .predict and .fit, yes?

@ardunn
Copy link
Contributor

ardunn commented Oct 2, 2018

I don't think the overall pipeline of matbench will take the form of an sklearn pipeline, since most of our underlying code uses dataframes and sklearn.Pipeline doesn't play nice with DataFrames sometimes...

@Qi-max can we close this issue?

@ardunn
Copy link
Contributor

ardunn commented Oct 15, 2018

Addressed more broadly in #92

@ardunn ardunn closed this as completed Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants