Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI for python 3.6 #259

Closed
ardunn opened this issue Oct 23, 2019 · 2 comments · Fixed by #263
Closed

Add CI for python 3.6 #259

ardunn opened this issue Oct 23, 2019 · 2 comments · Fixed by #263
Labels
bug bug

Comments

@ardunn
Copy link
Contributor

ardunn commented Oct 23, 2019

No description provided.

@janosh
Copy link
Member

janosh commented Oct 24, 2019

Discussed here.

@ardunn ardunn added the bug bug label Nov 8, 2019
@ardunn ardunn mentioned this issue Nov 10, 2019
Merged
@ardunn
Copy link
Contributor Author

ardunn commented Nov 10, 2019

@janosh I've added CI for python 3.6.7 and the quick tests are passing at least, so it might be worth trying on your 3.6 installation again. If you are still having problems we'll need to add a minimal unittest for it.

Also, I'd recommend upgrading to the new amm version (which I'll release in the next few days) as a lot of the latent memory issues (i.e., random segfaults) have been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add CI for 3.6 ardunn/automatminer
2 participants
@ardunn @janosh