Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid auto update check in development environment #181

Closed
Gisonrg opened this issue Aug 16, 2017 · 2 comments
Closed

Avoid auto update check in development environment #181

Gisonrg opened this issue Aug 16, 2017 · 2 comments
Labels
Milestone

Comments

@Gisonrg
Copy link
Contributor

Gisonrg commented Aug 16, 2017

Hi, thanks for this awesome product!

I tried to build it on my desktop, even though the app could start normally, I got this error:

Error: ENOENT, dev-app-update.yml not found

in the console. Google search leads me to this issue on electron-builder, and the suggestion from the discussion is to avoid doing auto update check in the dev environment.

Personally I felt it's meaningless to do the auto update check in development environment as well if we are creating the "latest" version 😛 )

We could try using the electron-is-dev to do the environment check as they suggested.

@hackjutsu
Copy link
Owner

@Gisonrg

Thanks for the suggestion :) Yes, it's meaningless to check for updates in a DEV environment. I'm OK with adopting the electron-is-dev package.

If you like, feel free to send a PR.

@hackjutsu hackjutsu added the dev label Aug 16, 2017
@Gisonrg
Copy link
Contributor Author

Gisonrg commented Aug 17, 2017

Cool, I will submit a PR when I am free over the weekend 👍

Sorry for mistakenly close the issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants