Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GSL #16

Closed
MichaelZhao21 opened this issue Apr 12, 2023 · 1 comment · Fixed by #35
Closed

Replace GSL #16

MichaelZhao21 opened this issue Apr 12, 2023 · 1 comment · Fixed by #35
Labels
A: Backend A task that concerns backend development A: Devops A task that concerns CI/CD and build pipelines B: Optimization An issue that is focused on optimizing something that works

Comments

@MichaelZhao21
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, the GSL library requires us to use debian:bullseye-slim.

Describe the solution you'd like

However, we can use a much smaller base image if we get rid of the GSL library dependency. We are LITERALLY only using it for rgsl::psi::diagamma::psi.

Additional context

No response
@MichaelZhao21 MichaelZhao21 added new feature New feature or request A: Backend A task that concerns backend development B: Optimization An issue that is focused on optimizing something that works and removed new feature New feature or request labels Apr 12, 2023
@Spaceface16518
Copy link

For context, the equivalent function in statsrs (which is pure rust, would be statically linked, and is already in use for betaln) is digamma.

@Spaceface16518 Spaceface16518 added the good first issue Good for newcomers label Apr 19, 2023
@MichaelZhao21 MichaelZhao21 added A: Devops A task that concerns CI/CD and build pipelines and removed good first issue Good for newcomers labels May 17, 2023
@MichaelZhao21 MichaelZhao21 mentioned this issue Jun 19, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: Backend A task that concerns backend development A: Devops A task that concerns CI/CD and build pipelines B: Optimization An issue that is focused on optimizing something that works
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed GSL dependency
2 participants
@Spaceface16518 @MichaelZhao21