Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Judge voting popup refactoring #107

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Judge voting popup refactoring #107

merged 2 commits into from
Jul 29, 2024

Conversation

MichaelZhao21
Copy link
Contributor

Description

Mostly reverting the behavior of the skip/flag popups. Also did a bit of refactoring for the generic popup components.

Fixes #104 and fixes #105

Type of Change

Delete options that do not apply:

  • Bug fix (change which fixes an issue)
  • Refactor (code changes that doesn't affect functionality)
  • (kind of) Revert (oopsie, undo a commit or change)

Is this a breaking change?

  • Yes
  • No

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jury ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 4:41am

@MichaelZhao21 MichaelZhao21 merged commit 9f49595 into master Jul 29, 2024
2 checks passed
@MichaelZhao21 MichaelZhao21 deleted the fix/popup branch July 29, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better generic popup component Revert Change to Flag/Busy/Skip popups
1 participant