Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned ratings slider #144

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Redesigned ratings slider #144

merged 6 commits into from
Sep 20, 2024

Conversation

veermshah
Copy link
Contributor

@veermshah veermshah commented Sep 12, 2024

Description

Made Rating Popup that Judges see have nicer sliders. Looks more pretty.

Fixes #99

Type of Change

  • Frontend

Is this a breaking change?

  • Yes
  • No

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jury ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 6:32pm

Copy link
Contributor

@MichaelZhao21 MichaelZhao21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label above slider needs to be changed, use the correct tailwind colors for the slider, and use tailwind's className wherever possible.

client/src/components/judge/Ratings.tsx Outdated Show resolved Hide resolved
client/src/components/judge/Ratings.tsx Outdated Show resolved Hide resolved
client/src/components/judge/Ratings.tsx Outdated Show resolved Hide resolved
client/src/components/judge/Ratings.tsx Outdated Show resolved Hide resolved
client/src/components/judge/Ratings.tsx Show resolved Hide resolved
client/src/components/judge/Ratings.tsx Show resolved Hide resolved
@veermshah
Copy link
Contributor Author

fixed the stuff

@MichaelZhao21 MichaelZhao21 self-requested a review September 19, 2024 23:13
@MichaelZhao21 MichaelZhao21 changed the title Slider/Range Redesigned ratings slider Sep 19, 2024
@veermshah veermshah merged commit 9a05003 into master Sep 20, 2024
2 checks passed
@veermshah veermshah deleted the slider branch September 20, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make judging rating popup less ugly
2 participants